Skip to content

Exposure fix for PS3EYEDriver in Windows and OSX.#152

Closed
cboulay wants to merge 7 commits into
thp:masterfrom
psmoveservice:ps3eye_fix
Closed

Exposure fix for PS3EYEDriver in Windows and OSX.#152
cboulay wants to merge 7 commits into
thp:masterfrom
psmoveservice:ps3eye_fix

Conversation

@cboulay
Copy link
Copy Markdown
Contributor

@cboulay cboulay commented Feb 13, 2015

Tracker should now work in low light when using PS3EYEDriver in OSX and Windows. Should close #150

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@thp
Copy link
Copy Markdown
Owner

thp commented Feb 15, 2015

Added some comments, please have a look. Also commented on https://github.com/thp/PS3EYEDriver/pull/4 -- we can/should probably only merge this (and fix the submodule reference to point to the merge commit) once the PS3EYEDriver PR is merged.

@cboulay
Copy link
Copy Markdown
Contributor Author

cboulay commented Feb 15, 2015

I agree that this PR shouldn't be merged yet, if at all. I put it forth mostly as an example of why we need the changes to PS3EYEDriver. Sorry I didn't come right out with that at the beginning.

Now that the PS3EYEDriver supports Windows, I think maybe it's a good idea to change platform/camera_control_<platform>.c to driver/camera_control_<driver>.c with "iSight", "PS3EYEDriver", "CLEYE", and "v4l2". Are there any others? How does Windows deal with non-CL or non-PS3EYE?

@thp
Copy link
Copy Markdown
Owner

thp commented Mar 1, 2015

This PR now has lots of whitespace changes. Please rebase and squash the commits and make sure you don't have unnecessary whitespace changes (spaces to tabs or vice versa) in there, it makes the diff hard to read.

@cboulay
Copy link
Copy Markdown
Contributor Author

cboulay commented Mar 1, 2015

Before I do that, maybe I can do it better. Where did you get the original values for minimum_exposure and maximum_exposure? And how did you know what transformations to apply when passing parameters to CLEYE?

@thp
Copy link
Copy Markdown
Owner

thp commented Mar 1, 2015

I think those were determined experimentally by @benniven back in summer 2012, he has written the CL Eye integration for Windows.

@cboulay
Copy link
Copy Markdown
Contributor Author

cboulay commented Mar 11, 2015

I couldn't rebase and squash because of the submodule. Instead I made a new, cleaner PR #162

@cboulay cboulay closed this Mar 11, 2015
@cboulay cboulay deleted the ps3eye_fix branch March 11, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The exposure settings, they do nothing. PS3Eye tracking only works in low lighting.

3 participants